search

danielstjules / Stringy

A PHP string manipulation library with multibyte support
MIT License
2.46k stars 216 forks source link

Issue 134 #135

Closed lucasmichot closed 8 years ago

lucasmichot commented 8 years ago

WIP on #134

All tests pass : https://travis-ci.org/danielstjules/Stringy/builds/124494966

Might be worth to SSH into the TravisCI container, if possible

lucasmichot commented 8 years ago

Ping @danielstjules

GrahamCampbell commented 8 years ago

mcrypt?

GrahamCampbell commented 8 years ago

mbstring?

lucasmichot commented 8 years ago

@GrahamCampbell - it's a WIP Yeah I know this is mbstring But I am mainly trying to find a way to do so, and mcrypt is by default on all Travis container

danielstjules commented 8 years ago

and mcrypt is by default on all Travis container

As is mbstring. Anyway, I'm not worried about it for now, see https://github.com/danielstjules/Stringy/issues/134#issuecomment-212506366 My bigger concern is either updating the polyfill or getting rid of it.

lucasmichot commented 8 years ago

My bigger concern is either updating the polyfill or getting rid of it.

At some point, I feel polyfill support should be removed

danielstjules commented 8 years ago

Closing for now - don't worry about it :) Travis doesn't support disabling extensions, and it's not worth compiling our own PHP from scratch.