danielstjules / Stringy

A PHP string manipulation library with multibyte support
MIT License
2.46k stars 216 forks source link

Fixes phpdoc for objects extending stringy. #153

Closed vpassapera closed 7 years ago

vpassapera commented 7 years ago

Non-code changes. Fixes hardcoded instances of Stringy objects to "static" instead so that any objects extending stringy can have sane autocompletion.

vpassapera commented 7 years ago

Any issues for merging this PR?

danielstjules commented 7 years ago

Should it be Stringy|static or does static suffice? Sorry, I'd never seen this return type before :)

vpassapera commented 7 years ago

Static suffices, it's basically the php doc for the late static bindings. the IDE resolves it automatically. Thank you!

danielstjules commented 7 years ago

Neat :) Thanks!

vpassapera commented 7 years ago

Thanks for the awesome library!