search

danieluhm2004 / serverless-webpack-prisma

When using serverless webpack, you can save up to 50% of package capacity by deleting unnecessary Prisma engine.
https://www.npmjs.com/package/serverless-webpack-prisma
MIT License
33 stars 27 forks source link

Also remove engines in the prisma/engines directory #12

Closed Eosis closed 1 year ago

Eosis commented 2 years ago

We were finding that extra, seemingly duplicated prisma engines were being output to this directory, so added this new glob pattern to match and remove them. This has not been widely tested to confirm suitability for all workflows or environments, though I've raised a pull request in case others find this useful.

andreyevyk commented 2 years ago

This PR will resolve my problem too

danieluhm2004 commented 2 years ago

Hello. I'm sorry about the late reply and I appreciate your pull request.

I was confirming your pull request. But I can't find the "node_modules/prisma" directory in my packaged serverless zip file.

I know it's bothersome, But if you or anyone have a "node_modules/prisma" directory in your packaged serverless zip, Please share your project or make a repro repository.

Plus, below is my Prisma information.

@prisma/client          : 4.0.0
Current platform        : debian-openssl-1.1.x
Query Engine (Node-API) : libquery-engine da41d2bb3406da22087b849f0e911199ba4fbf11 (at ../../node_modules/@prisma/engines/libquery_engine-debian-openssl-1.1.x.so.node)
Migration Engine        : migration-engine-cli da41d2bb3406da22087b849f0e911199ba4fbf11 (at ../../node_modules/@prisma/engines/migration-engine-debian-openssl-1.1.x)
Introspection Engine    : introspection-core da41d2bb3406da22087b849f0e911199ba4fbf11 (at ../../node_modules/@prisma/engines/introspection-engine-debian-openssl-1.1.x)
Format Binary           : prisma-fmt da41d2bb3406da22087b849f0e911199ba4fbf11 (at ../../node_modules/@prisma/engines/prisma-fmt-debian-openssl-1.1.x)
Default Engines Hash    : da41d2bb3406da22087b849f0e911199ba4fbf11
Studio                  : 0.465.0

Have a nice day. Thank you.

zkSoju commented 2 years ago

This PR would fix my issues as well! Please merge.

danieluhm2004 commented 2 years ago

Hi @zkSoju I appreciate about interest in my library.

I tried on Prisma v3.11.0 and v4.0.0, v4.5.0 and also tested on Windows 10 and MacOS. But I can't still find the node_modules/prisma/engines directory.

I know it really tiresome, But please make a repro repository and share it. So I can get the same environment as yours.

+ Can you also test after you take Prisma upgrade to latest version?

Thank you.