danielvijge / SqueezeCloud

SoundCloud plugin for Squeezebox
GNU General Public License v2.0
25 stars 11 forks source link

provider shall return empty hash when nothing is found #34

Closed philippe44 closed 3 years ago

philippe44 commented 3 years ago

The metadata_provider function returns a hash with almost nothing when it does not have anything in cache. I think it should return an empty hash (because it's a provider). Otherwise, other services that use soundcloud to retrieve content (e.g.) podcast will see their getMetadataFor result preempted by the soundcloud plugin's metadata_provider. I think likely the registerProvider should be narrower in term of what it captures as well, but I'll let you decide