chore: rewrite file watcher - Githubissues

danielwaltz / vite-plugin-graphql-codegen

Zero-config vite plugin that uses the vite file watcher to run graphql codegen programmatically without needing to start a separate watcher

https://www.npmjs.com/package/vite-plugin-graphql-codegen

MIT License

83 stars 8 forks source link

chore: rewrite file watcher #32

Open yurks opened 5 months ago

yurks commented 5 months ago

Currently, file watcher asynchronously retrieves documents and schemas on each project file changes, which is slow, and caused unreasonably high resources usage.

Changes made

resolve all configured documents and schemas only once on server startup and simply check file path matching in watcher.
fix cases when schema path defined with dot like ./src/schema.graphql by resolve absolute schema paths.
fix cases when documents defined with glob pattern like ./src/**/*.graphql, and modifying src/path/api.graphql.generated.ts file caused false positive check and trigger watcher for that file.

Also, this PR should resolve OOM issues reported in https://github.com/danielwaltz/vite-plugin-graphql-codegen/issues/27

Side changes

reduce amount of log records, as currently it contains a lot of records which is not related to plugin: modifying any file in project produces ~5 log entries. Below are screenshots of the same number of interactions with project files demonstrating this.

Before

After

danielwaltz commented 5 months ago

Thanks for your effort on these PRs! Hope to carve out the time in the next week or so to test them out and get them merged. 🎉