search

danielwaltz / vite-plugin-graphql-codegen

Zero-config vite plugin that uses the vite file watcher to run graphql codegen programmatically without needing to start a separate watcher
https://www.npmjs.com/package/vite-plugin-graphql-codegen
MIT License
83 stars 8 forks source link

Adds schema to the isGraphQLDocument check #8

Closed andrew-w-ross closed 2 years ago

andrew-w-ross commented 2 years ago

Closes #7

danielwaltz commented 2 years ago

@andrew-w-ross Only possible strange aspect about this solution (purely from a semantic point of view) is the name of the utility being isGraphQLDocument. With it also checking the schema(s), I feel like a less specific name might be better now, or splitting the schema match check into its own separate utility.

Just spitballing names, I could see isGraphQLFile or isGraphQLRelated or something along those lines. Not the biggest fan of either idea so I'm open to other options!

Also before merge I think this commit name should also follow the conventional commit format, not sure if this falls into a fix: or a feat:, but either way we'll need it to release it!

Appreciate your contributions a lot!

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: