danielward27 / flowjax

https://danielward27.github.io/flowjax/
MIT License
85 stars 10 forks source link

60 add vi helper #63

Closed Tennessee-Wallaceh closed 1 year ago

Tennessee-Wallaceh commented 1 year ago

Initial solution to #60.

Key points:

danielward27 commented 1 year ago

Nice, I can add in the sample_and_log_prob method.

danielward27 commented 1 year ago

I've added the sample_and_log_prob method in https://github.com/danielward27/flowjax/pull/65, so the training script should be updated to use that.

danielward27 commented 1 year ago

By the way, I have no strong feelings about "train" vs "fit", but feel that we should be consistent and use one or the other and not both.

Tennessee-Wallaceh commented 1 year ago

By the way, I have no strong feelings about "train" vs "fit", but feel that we should be consistent and use one or the other and not both.

How about fit_to_data and fit_to_variational_target?