search

danielward27 / flowjax

https://danielward27.github.io/flowjax/
MIT License
85 stars 10 forks source link

VI #69

Closed danielward27 closed 1 year ago

danielward27 commented 1 year ago

A few minor changes:

  1. I put the key as the first argument for ELBO loss (in general most random functions and classes in the package take key as the first argument, so this is just for consistency).
  2. I renamed epochs to steps, as in train_flow an epoch is composed of multiple steps, so it felt unclear to have epoch mean a single step.

@Tennessee-Wallaceh Could you give this a quick look and check you are happy?

Tennessee-Wallaceh commented 1 year ago

All looks good to me, nice changes that improve consistency. I will merge this.