danielweidman / pixmob-ir-reverse-engineering

Hacking the PixMob infrared (and now also RF!) protocol to enable control of PixMob wristbands at home.
MIT License
594 stars 42 forks source link

Initialize SKIP_FIRST_N_CODES #18

Closed zacharesmer closed 1 year ago

zacharesmer commented 1 year ago

Description

The variable SKIP_FIRST_N_CODES is not initialized, and it should be initialized to 0 so it does not cause an error.

Fixes part of this comment in issue #10

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

Checklist:

danielweidman commented 1 year ago

Excellent! Thank you for noticing and fixing this (and for the detailed writeup).

sean1983 commented 1 year ago

Thanks for fixing this this @zacharesmer

This had been driving me mad, I just kept fixing it each time myself but I was wasn't using github properly it never got found by anyone else and fixed until now 👍