search

danielweinmann / react-native-stateless-form

Stateless form components for React Native
MIT License
105 stars 14 forks source link

Migration to redux-form v6 #3

Open ms88privat opened 8 years ago

ms88privat commented 8 years ago

Since redux-form v6 is a complete rewrite, it has breaking API changes. One of them is the need to wrap your Inputs inside a <Field/> element.

This line and maybe some other things should get adjusted in your code. I will try it tomorrow by my self.

http://redux-form.com/6.0.0-alpha.7/docs/GettingStarted.md/

Are there any plans from your side to migrate?

Thanks a lot

danielweinmann commented 8 years ago

Hi, @ms88privat!

I'll surely want to use redux-form v6 in future projects, so I'll probably implement something in the future if nobody does it before me.

But if you need it right now, I'll gladly accept PRs for that ;) I don't think we should change InlineTextInput right now, though. It would be better to create a new widget called InlineTextField that works with v6. And then specify the differences on the README.

What do you think of this suggestion?

ms88privat commented 8 years ago

@danielweinmann I tried to get it working, but I was not able too. For now I switched back to v5. https://github.com/erikras/redux-form/issues/927

Also I run into another issue. The styles seems to break after iOS production build. It is working in dev mode. image

ms88privat commented 8 years ago

I solved the style problem. It is caused by the 0.5 borderWith. We could move to StyleSheet.hairlineWidth