search

danielwelch / django-q-sentry

Bringing Sentry error tracking to Django Q
MIT License
8 stars 7 forks source link

fix poetry.dependencies issue #10

Closed wtracyliu closed 3 years ago

wtracyliu commented 4 years ago

pr to solve #9

according the documentation of poetry https://python-poetry.org/docs/dependency-specification/ , ^0.16.5 means >=0.16.5 <0.17.0 , so I think it's better to change ^0.16.5 to >=0.16.5

s-agawane commented 4 years ago

@wtracyliu Is this the reason I am not able to upgrade to sentry 0.17 ?

wtracyliu commented 4 years ago

@s-agawane I think so, actually after pip install my forked version ,I've upgraded sentry to 0.19.1. I've never used poetry before, so I looked up in the documentation, I think that's the problem.

gilmrjc commented 3 years ago

Yes, this fixes the problem because ^0.16.5 locks to versions in the 0.16.x releases and the resolution blocks a manual installation of 0.17.0 and above to comply with the package constrains. @danielwelch just a friendly ping for this 🙏

c-goosen commented 3 years ago

Sorry for the delay on this @wtracyliu.

Merging in fix. Will do a build to pypi as well.