search

danielwelch / hassio-dropbox-sync

Back up your Hass.io snapshots and other local files to Dropbox
Apache License 2.0
132 stars 37 forks source link

If upload fail and keep_last is configured, it will still delete those snapshots locally #23

Open ErikHells opened 5 years ago

ErikHells commented 5 years ago

If the add-on for some reason cannot upload to the dropbox account (e.g. in my case I had an oauth-key that was faulty) and the keep_last option is configured, the addon will still delete snapshots even though the upload failed.

The add-on should cross check if the upload of a specific snapshot was successful and if it was, delete it locally (if keep_last is configured and the snapshot is eligible for deletion.)

`> Uploading "/backup/081caadf.tar" to "/Private/Home Automation/ha-snapshots"... FAILED An error occurred requesting /upload

Uploading "/backup/25edc2b6.tar" to "/Private/Home Automation/ha-snapshots"... FAILED An error occurred requesting /upload Uploading "/backup/571f7161.tar" to "/Private/Home Automation/ha-snapshots"... FAILED An error occurred requesting /upload Uploading "/backup/68a6142d.tar" to "/Private/Home Automation/ha-snapshots"... FAILED An error occurred requesting /upload Uploading "/backup/762fe520.tar" to "/Private/Home Automation/ha-snapshots"... FAILED An error occurred requesting /upload Uploading "/backup/c1fbefc2.tar" to "/Private/Home Automation/ha-snapshots"... FAILED An error occurred requesting /upload Some error occured. Please check the log. [Info] keep_last option is set, cleaning up files... [Info] Deleted snapshot 571f7161 [Info] Deleted snapshot c1fbefc2 [Info] Deleted snapshot 762fe520`

jazzmonger commented 4 years ago

Is the dev even looking at thus addon any longer?

Thus issue is pretty major...