danielwerg / r6api.js

🍫 Node.js wrapper around Rainbow Six Siege APIs
https://npm.im/r6api.js
MIT License
111 stars 19 forks source link

New diamond rank tiers and ranks objects naming #68

Closed danielwerg closed 2 years ago

danielwerg commented 3 years ago

Current: before Test server: after

Will have to add another ranks object when it's released to live build, anyone got ideas for better naming over that we currently have? (RANKS and OLD_RANKS), don't want to call it NEW_RANKS, it will only make it more confusing.

code ref

BadCoder1337 commented 3 years ago

Something like

So bump a major version, this is a breaking change anyway.

danielwerg commented 3 years ago

Got this so far:

// Original
export const RANKSV1 = <const>{
  0: 'Unranked',
  1: 'Copper 1', 2: 'Copper 2', 3: 'Copper 3', 4: 'Copper 4',
  5: 'Bronze 1', 6: 'Bronze 2', 7: 'Bronze 3', 8: 'Bronze 4',
  9: 'Silver 1', 10: 'Silver 2', 11: 'Silver 3', 12: 'Silver 4',
  13: 'Gold 1', 14: 'Gold 2', 15: 'Gold 3', 16: 'Gold 4',
  17: 'Platinum 1', 18: 'Platinum 2', 19: 'Platinum 3',
  20: 'Diamond'
};

// Velvet Shell (5) - Phantom Sight (14)
export const RANKSV2 = <const>{
  0: 'Unranked',
  1: 'Copper 4', 2: 'Copper 3', 3: 'Copper 2', 4: 'Copper 1',
  5: 'Bronze 4', 6: 'Bronze 3', 7: 'Bronze 2', 8: 'Bronze 1',
  9: 'Silver 4', 10: 'Silver 3', 11: 'Silver 2', 12: 'Silver 1',
  13: 'Gold 4', 14: 'Gold 3', 15: 'Gold 2', 16: 'Gold 1',
  17: 'Platinum 3', 18: 'Platinum 2', 19: 'Platinum 1',
  20: 'Diamond'
};

// Ember Rise (15) - North Star (22)
export const RANKSV3 = <const>{
  0: 'Unranked',
  1: 'Copper 5', 2: 'Copper 4', 3: 'Copper 3', 4: 'Copper 2', 5: 'Copper 1',
  6: 'Bronze 5', 7: 'Bronze 4', 8: 'Bronze 3', 9: 'Bronze 2', 10: 'Bronze 1',
  11: 'Silver 5', 12: 'Silver 4', 13: 'Silver 3', 14: 'Silver 2', 15: 'Silver 1',
  16: 'Gold 3', 17: 'Gold 2', 18: 'Gold 1',
  19: 'Platinum 3', 20: 'Platinum 2', 21: 'Platinum 1',
  22: 'Diamond',
  23: 'Champions'
};

// Crystal Guard (23) and above
export const RANKSV4 = <const>{
  0: 'Unranked',
  1: 'Copper 5', 2: 'Copper 4', 3: 'Copper 3', 4: 'Copper 2', 5: 'Copper 1',
  6: 'Bronze 5', 7: 'Bronze 4', 8: 'Bronze 3', 9: 'Bronze 2', 10: 'Bronze 1',
  11: 'Silver 5', 12: 'Silver 4', 13: 'Silver 3', 14: 'Silver 2', 15: 'Silver 1',
  16: 'Gold 3', 17: 'Gold 2', 18: 'Gold 1',
  19: 'Platinum 3', 20: 'Platinum 2', 21: 'Platinum 1',
  22: 'Diamond 3', 23: 'Diamond 2', 24: 'Diamond 1',
  25: 'Champions'
};

Still need to double check for typos.