search

danielwerg / r6api.js

🍫 Node.js wrapper around Rainbow Six Siege APIs
https://npm.im/r6api.js
MIT License
111 stars 19 forks source link

Package can't be installed from GitHub #88

Closed EndBug closed 2 years ago

EndBug commented 2 years ago

As of now, if the package gets installed from GitHub it won't be compiled, and so it will not be usable. A solution to this would be adding a prepare script that checks whether the dist folder is already there, otherwise runs the build script. A working example is dbots.js: https://github.com/dbots-pkg/dbots.js/blob/adb1219db00a1d11daece7e2309834fa33a3e963/package.json#L18

What do you think?

danielwerg commented 2 years ago

As long as it doesn't interfere with npm package — I'm for it.