search

danielwertheim / Ensure.That

Guard clause project for .NET
MIT License
439 stars 49 forks source link

Breaking change from 8.1.2 to 8.2.0 #136

Closed barakakha closed 4 years ago

barakakha commented 4 years ago

i got this error after upgrading from 8.1.2 to 8.2.0 image

this error was raised when trying to use version 8.2.0 with other nuget that was already compiled with version 8.1.2. to be more clear Project A (with 8.2.0) ---> Nuget X ---> Ensure.That.8.1.2

danielwertheim commented 4 years ago

Yes, you are correct. Mistake. I'm not keen on reverting that PR.

What do you think about putting out a new package as v9.0.0 and "unlist" 8.2.0?

barakakha commented 4 years ago

Sounds good

danielwertheim commented 4 years ago

Done. 8.2.0 has been marked as deprecated and points at 8.1.2 instead. And v9.0.0 has been released. Thanks for reporting.

ndrwrbgs commented 4 years ago

I do think we should consider releasing a minor version bump that reverts it on the 8.* path. Having been on the receiving end of this kind of change before, having a "latest" that fixes it helps if I consume a package that consumed it but hasn't updated to latest or rolled back.

I guess concern is alleviated if we have a way to see on nuget if any packages are saying >=8.2.0

On Wed, Apr 29, 2020, 12:44 PM Daniel Wertheim notifications@github.com wrote:

Done. 8.2.0 has been marked as deprecated and points at 8.1.2 instead. And v9.0.0 has been released. Thanks for reporting.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/danielwertheim/Ensure.That/issues/136#issuecomment-621419520, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSHCOUZQCWIUEFAOXZ7S6LRPB7SDANCNFSM4MO5A52A .