search

danielwippermann / resol-vbus-java

A Java library for processing RESOL VBus data
7 stars 7 forks source link

Localization of DeviceNames Missing #5

Closed ramack closed 6 years ago

ramack commented 6 years ago

Specification.getSourceDeviceSpec(packet).getName() always returns the German device name, e.g. "DeltaSol MX [Regler]" insteaf of "DeltaSol MX [Controller]". I guess this is an issue in the VSF and not in the java code, but never the less it is not soo nice any maybe you find a way to fix that. If not; I, as a German, can also live with it, just close this issue with a wontfix tag :-)

danielwippermann commented 6 years ago

Version 8 of the VSF should fix most of the German / English localization problems. It is scheduled to be releases in January. I'll keep this issue open until the VSF is updated in this repo.

ramack commented 6 years ago

thanks for the update

ramack commented 6 years ago

any news about the release of the VSF?

danielwippermann commented 6 years ago

Approval of the file took longer than expected but finally passed today. VSF and corresponding tests were updated in f6264bab6b356ed3dda73deddd10d9b2be047c6c.

ramack commented 6 years ago

looks great now. Thanks for fixing.