search

danielwippermann / resol-vbus-java

A Java library for processing RESOL VBus data
7 stars 7 forks source link

Integration of resol-vbus-java #6

Closed ramack closed 6 years ago

ramack commented 6 years ago

What is the was to integrate resol-vbus-java into other projects, like an OpenHAB binding for example. Copying the code is not so clean. Is there a way to use maven to integrate a tagged version of this library here? Or should we think of a jar distributable?

danielwippermann commented 6 years ago

To be honest: I have no clue and always deferred that decision until somebody actually wanted to use the lib :) If I had to decide a way on my own I thing I would have followed this StackOverflow answer on how to deploy artifacts to GitHub. But since I don't write Java for a living anymore I don't know the state-of-the-art way to solve this, so I'm open for alternative suggestions!

ramack commented 6 years ago

I asked for the best practice about including libraries in openhab bindings, but as I did not get a single answer, I would like to go the plain-jar-inclusion way.

What do you think about just putting a .jar of your library into the repo (maybe in a new branch) and tag it with a version name?

danielwippermann commented 6 years ago

Sounds good to me.

I created a branch "releases", bumped all version identifiers and tagged the current state of the repo as "v0.2.0", built a JAR file from it and put it on the "releases" branch tagged as "rel-v0.2.0".

That way it should be easy to identify which source code belongs to which release.

danielwippermann commented 6 years ago

I close this for now, feel free to reopen it or create a new issue if you think this is not solved yet.

ramack commented 4 years ago

In the Changelog the release 0.3 is documented, but neither a tag nor a release jar is available. Could you do me the favor and build the jar for 0.3?

danielwippermann commented 4 years ago

You can find the JAR under the (freshly created) GitHub release for 0.3.0: https://github.com/danielwippermann/resol-vbus-java/releases/tag/v0.3.0

ramack commented 4 years ago

thanks a lot!