search

danielxjean / EngLife

This repository will be used for our application named "EngLife" that will be completed for SOEN341.
0 stars 0 forks source link

Groups #81

Closed danielxjean closed 4 years ago

danielxjean commented 4 years ago

Making another pull request because last time the build fail

KevKevR commented 4 years ago

Please, could you revert your branch to the state of your previous pull request? The issue back then was because of register_test.dart trying to call the register method with three arguments, when you modified it to have five parameters instead. Some of the changes you made like removing the keys just makes it worse by breaking the tests (the tests rely on the keys to locate the proper fields to interact with). If you could revert your changes, I can modify the methods in the tests to check with five arguments instead. Here's the previous pull request's change to the method signature: https://github.com/danielxjean/EngLife/blob/8394042730cfe9013bef4055fc8ae4c7f9d0e6f5/eng_life/lib/services/auth.dart#L114 ... and here's a line (out of many) in register_test.dart that still used the previous signature: https://github.com/danielxjean/EngLife/blob/8394042730cfe9013bef4055fc8ae4c7f9d0e6f5/eng_life/test/register_test.dart#L84

Also bit of a tangent, but it'd be great if merging would require having two reviewers agree to the changes, so these panic changes wouldn't have to be done.

danielxjean commented 4 years ago

We have resolved this through a call on April 6th on a Zoom, it can now be closed.

KevKevR commented 4 years ago

Specifically, the branch diverged and was merged with another one, and then that one merged into master. See #82 and #83.