search

danielyaa5 / puml-for-markdown

A CLI tool to embed interactive PUML diagrams to your github markdown files.
MIT License
296 stars 62 forks source link

Option to use a different plantuml server #2

Closed dannief closed 2 years ago

dannief commented 2 years ago

Would like to try this. Can you add an option to change the plantuml server?

danielyaa5 commented 2 years ago

Ya good idea, is it enough to just make this constant an option? https://github.com/danielyaa5/puml-for-markdown/blob/main/index.js#L22 or would there need to be other tweaks?

dannief commented 2 years ago

Great. That should be enough

danielyaa5 commented 2 years ago

Can you try this PR #3 ? You should be able to clone this and run node bin/index.js --puml-server-url <url> --root-directory <path-to-your-project>

danielyaa5 commented 2 years ago

I was able to test this with a docker instance https://github.com/plantuml/plantuml-server I will merge it now. Just note this server url would need to be public not localhost for rendering the images in the markdown but if you just want to use links should still work fine

danielyaa5 commented 2 years ago

you should be able to update your npm package and try it out now