GIANT is not a minion type

danielyule / hearthbreaker

A Hearthstone: Heroes of WarCraft Simulator for the purposes of Machine Learning and Data Mining

MIT License

506 stars 122 forks source link

GIANT is not a minion type #123

Closed tonyyyye closed 6 years ago

tonyyyye commented 6 years ago

MINION_TYPE should only include explicit type name. Nightmare amalgam defines all other types of minions, which are: Elemental, Mech, Demon, Murloc, Dragon, Beast, Pirate and Totem

GIANT is not a named type, although giants do have common features.

tonyyyye commented 6 years ago

All types are now implied by Nightmare Amalgam

danielyule commented 6 years ago

Hey,

As you might have noticed, work has pretty much ceased on this project. I'm happy to accept pull requests, and any contributions, but I don't personally plan to put any work into it in the foreseeable future. If you're interested, there are a couple of other simulators under active development over at https://hearthsim.info/

tonyyyye commented 6 years ago

Thanks.