danielyxie / bitburner

Bitburner Game
https://danielyxie.github.io/bitburner/
2.8k stars 776 forks source link

DOCUMENTATION: UPDATED EXAMPLE FOR PASSING ARGUMENTS ON NS2 SCRIPT EXECUTION #4266

Closed marcowesii closed 1 year ago

marcowesii commented 1 year ago

Updated the example on ns2 scripts with passing arguments using currently working example and better formatting.

DOCUMENTATION: UPDATED EXAMPLE FOR PASSING ARGUMENTS ON NS2 SCRIPT EXECUTION

Snarling commented 1 year ago

Repo is now located at github.com/bitburner-official/bitburner-src

ModestMC commented 1 year ago

I just spent 45 minutes first figuring out this bug, then going and writing a PR, then checking to see if anyone else had this issue. The doc file in the updated source repo at least explains something (though I'm not getting it to run correctly), but the webpage still has the old version in this repo. Will submit the PR to the new repo.

marcowesii commented 1 year ago

Thanks for patience, I'm sorry I had to make you waste time, I'm not very experienced of github, so maybe I did something wrong. 😢 If you want I can close the PR. Let me know. Are you referring to this? FAIL test/jest/Script/Script.test.ts ● Test suite failed to run

Cannot find module '@player' from 'src/Netscript/RamCostGenerator.ts'

Require stack:
  src/Netscript/RamCostGenerator.ts
  src/Script/RamCalculations.ts
  src/Script/Script.ts
  test/jest/Script/Script.test.ts

> 1 | import { Player } from "@player";
    | ^
  2 | import { NSFull } from "../NetscriptFunctions";
  3 |
  4 | /** This type assumes any value that isn't an API layer or a function has been omitted (args and enum) */

  at Resolver.resolveModule (node_modules/jest-resolve/build/resolver.js:322:11)
  at Object.<anonymous> (src/Netscript/RamCostGenerator.ts:1:1)

Test Suites: 5 failed, 3 passed, 8 total Tests: 53 passed, 53 total Snapshots: 0 total Time: 3.158 s Ran all test suites. Error: Process completed with exit code 1.