search

daniestevez / gr-satellites

GNU Radio decoder for Amateur satellites
GNU General Public License v3.0
777 stars 161 forks source link

Make HDLC Framer pass the metadata from the input pdu to the output pdu #445

Closed Niautanor closed 1 year ago

Niautanor commented 1 year ago

This allows setting the "tx_time" attribute that is required by some SDRs to time the transmission of a burst (e.g. the LimeSDR) in the block that generates the data to be HDLC encoded (since PDU to tagged stream applies all the metadata keys of the pdu as additional tags on the first sample).

If there is a use case for having this block explicitly not propagate metadata, I can add a configuration parameter to enable this new behavior conditionally.

daniestevez commented 1 year ago

Thanks! I can't think of a use case in which metadata shouldn't be propagated. If that case comes up, it is perhaps better to have a block that drops the metadata, since that could be used in combination with any of the other blocks.