search

daniestevez / gr-satellites

GNU Radio decoder for Amateur satellites
GNU General Public License v3.0
758 stars 156 forks source link

refactor snet support #508

Open Gioyik opened 11 months ago

Gioyik commented 11 months ago

As part of a university project, I got access to more information related to SNET satellites, this adds and introduces changes in telemetry to get closer to the specification of SNET.

Gioyik commented 11 months ago

I am not sure why the tests are failing, as it seems, they are not related to the changes I made.

daniestevez commented 11 months ago

I think the tests are failing because the satellites Python module cannot be imported due to the changes you made. The error message in the tests is not very helpful, though, but you can check what import satellites says on your machine.

Gioyik commented 11 months ago

@daniestevez I think I addressed most of your comments and requests for changes, could you please give it a check again?

This time, I added an Adapter for the MemData32 and changed the norad values accordingly to this reference: https://web.archive.org/web/20200106160215/http://dk3wn.info:80/blog/satelliten/s-net/

daniestevez commented 10 months ago

By the way, can you share how you're testing this code? The fact that BitsInteger(32) when not inside a bitwise context consumes 32 bytes instead of 4 makes me suspect that your test cases are not good enough.