search

danigb / smplr

A web audio sampler instrument
https://danigb.github.io/smplr/
188 stars 19 forks source link

Drum Machine: Roland missing ogg files, sampleNames issue with MFB-512 #70

Closed drscottlobo closed 7 months ago

drscottlobo commented 8 months ago

Hi danigb! OK, so playing around with the drum machines, and they mostly work great! I found a couple issues:

The Roland CR-8000 appears to be missing its samples, when I load it, they all come back with an error like this one:

"Error loading buffer. Invalid status: 404 https://danigb.github.io/samples/drum-machines/Roland-CR-8000/cr8kcowb.ogg"

All the sampleNames in that instrument appear to be formatted differently than the others as well, perhaps the sample names are the problem, when I look at the list, rather than human readable names I get:

Cr8kbass Cr8kchat Cr8kclap Cr8kclav Cr8kcowb Cr8kcymb Cr8khitm Cr8klcng Cr8klotm Cr8kmcng Cr8kohat Cr8krim Cr8ksnar

A similar issue happens with the MFB-512, the samples on that drummachine load fine, but the sampleNames come up as:

512bdrum 512clap 512cymb 512hhcl 512hhop 512hitom 512lotom 512mdtom 512snare

All the other Drum Machines work as expected!

You can see my work-in-progress drum sampler, and if you click the dropdown and choose either the Roland or the MFB you should see the incorrect(?) sampleNames coming up along the lanes, and the console will show the missing files on the Roland.

drscottlobo commented 7 months ago

Any progress on this?

danigb commented 7 months ago

Sorry for the late replay. This should be fixed in the latest version.

drscottlobo commented 7 months ago

Thank you! I’ll have a look today!___Scott Wolf, DMAOxnard College - Professor of MusicOn Apr 11, 2024, at 8:42 AM, danigb @.***> wrote: Sorry for the late replay. This should be fixed in the latest version.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

drscottlobo commented 7 months ago

Yep! Working as expected thanks!

On Thu, Apr 11, 2024 at 8:42 AM danigb @.***> wrote:

Sorry for the late replay. This should be fixed in the latest version.

— Reply to this email directly, view it on GitHub https://github.com/danigb/smplr/issues/70#issuecomment-2049991227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVT3RFR6XHV77OLCYGD2ILY42VMPAVCNFSM6AAAAABFDNUJB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZHE4TCMRSG4 . You are receiving this because you authored the thread.Message ID: @.***>

-- Scott Wolf, DMA Oxnard College - Professor of Music www.scottwolfguitar.com

All Strings Considered http://www.scottwolfguitar.com/podcast.html Follow on Twitter - @allstrings https://twitter.com/allstrings Subscribe free on iTunes https://itunes.apple.com/us/podcast/all-strings-considered/id562425515 - Subscribe - Please Rate!