search

danigeos / tisc

TISC is a code to model isostasy, erosion/sediment transport/sedimentation, and tectonic kinematics, mostly for the study of sedimentary basins and source to sink systems.
https://sites.google.com/site/daniggcc/software/tisc
16 stars 2 forks source link

nan values in drainage.masstr #17

Open mberry28 opened 6 years ago

mberry28 commented 6 years ago

I have noticed that nan values surface in in .bas and .xyw files that are printed from drainage.masstr.

It usually seems to occur along a specific river. Any reason for this or anything that can be done to prevent it?

Thanks

mberry28 commented 6 years ago

After several days of working with it, it turns out, that is was a eros_bound_cond issue.

danigeos commented 6 years ago

Thanks, Michael, i'll try check this when i find some time. What was the value making trouble?

On Thu, Dec 7, 2017 at 4:33 AM, Michael Berry notifications@github.com wrote:

After several days of working with it, it turns out, that is was a eros_bound_cond issue.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/danigeos/tisc/issues/17#issuecomment-349852922, or mute the thread https://github.com/notifications/unsubscribe-auth/ALBQivH8SstyKKNdTP-yT9ZJ-QvKkkzGks5s91yWgaJpZM4Q1bnp .

mberry28 commented 6 years ago

Hi Daniel,

It was the drainage.masstr (sediment discharge) values. I noticed that the streams that had issues were often touching boundaries (at their head or exit point), so I just changed the eros_bound_cond and it seemed to fix the issue. I attached a plot of the sed discharge values. White locations were where nan values occurred, other time steps where worse.

I changed the condition to 1111. Instead of the default (I think 0000?)

mass_out_

danigeos commented 6 years ago

well done, congrats!

On Thu, Dec 21, 2017 at 8:02 PM, Michael Berry notifications@github.com wrote:

Hi Daniel,

It was the drainage.masstr (sediment discharge) values. I noticed that the streams that had issues were often touching boundaries (at their head or exit point), so I just changed the eros_bound_cond and it seemed to fix the issue. I attached a plot of the sed discharge values. White locations were where nan values occurred, other time steps where worse.

I changed the condition to 1111. Instead of the default (I think 0000?)

[image: massout] https://user-images.githubusercontent.com/13278376/34270763-8ca2002e-e646-11e7-8b36-ec143749a66f.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/danigeos/tisc/issues/17#issuecomment-353431167, or mute the thread https://github.com/notifications/unsubscribe-auth/ALBQigqyu2H2nVLk651Qc2z5XH7ijHjtks5tCqtcgaJpZM4Q1bnp .