search

danigm / spotify-ad-blocker

GNOME shell extension to mute spotify ads
GNU General Public License v3.0
57 stars 8 forks source link

Add volume reduction #19

Closed bmaupin closed 1 year ago

bmaupin commented 1 year ago

Closes #18

@danigm A few notes:

  1. I'm relatively new to Gnome Extension development. Of course I tested the code and it works as expected (for me), but feel free to modify it as you see fit. I got a lot of the code (e.g. prefs.js) straight from the examples at https://gjs.guide/extensions
  2. The schema XML in schemas/ needs to be compiled. I didn't add the compiled file (schemas/gschemas.compiled) to the PR because it's a binary file and I wasn't sure if it should be part of the publishing process? I've just been compiling it locally for testing using the command from here: https://gjs.guide/extensions/development/preferences.html#compiling-a-schema
  3. Lastly, I have a couple other additions I'll probably make, such as adding an item to the preferences page to make the unmute delay (currently 500 ms) user-configurable. And if it's not too much work I'll try to tackle #6 as well. Would you prefer I add those to this PR or create separate PRs for those?

Thanks!

danigm commented 1 year ago

I've just uploaded a new version to extensions.gnome.org with your change included https://extensions.gnome.org/review/42411