search

danihodovic / celery-exporter

A Prometheus exporter for Celery metrics
MIT License
399 stars 87 forks source link

Add queues priority to metrics only works in redis #204

Closed ahelmy closed 1 year ago

ahelmy commented 1 year ago

https://github.com/danihodovic/celery-exporter/pull/196 @danihodovic

danihodovic commented 1 year ago

Could we add a test for this?

ahelmy commented 1 year ago

It would be hard for the moment, I need to understand how test working in this repo. But I tested locally and works perfect with redis.

danihodovic commented 1 year ago

We will need a test to prevent future changes from breaking this logic. I can give you some help with the test, but the earliest would be later this month. We use Redis, but not queue priorities so it's not a pressing matter for us.

ahelmy commented 1 year ago

appreciating your guidance, priority queue could be applied to Redis as well and its used normally so important to support that

ahelmy commented 1 year ago

@danihodovic Please find unit testing, late better than nothing :D

danihodovic commented 1 year ago

Hi @ahelmy,

Sorry about the long time until review. I've been busy with other projects.

I think adding queue priority is a seldom used feature (especially with Redis) and it complicates the celery-exporter code. At the moment I prefer not to merge it as I'm not using it in any of my projects and this is the first feature request I get.

If you would like to support it please fork the project.

Thank you, Dani