danihodovic / django-allauth-ui

Nice looking templates for django-allauth
https://django-allauth-ui.hodovi.ch
MIT License
202 stars 24 forks source link

Why is the "remember" field excluded from login.html? #39

Open Hyperz opened 6 months ago

Hyperz commented 6 months ago

I'm referring to this. Is there a reason the "Remember me" checkbox is being excluded from the form entirely?

danihodovic commented 6 months ago

I can't remember why I made that decision. We should add it. Do you want to open a PR?

Instructions here: https://github.com/danihodovic/django-allauth-ui#hacking-on-the-project

Hyperz commented 6 months ago

Looking at what happens when the conditional is removed maybe it was put there to not give the checkbox the same look/styling as the email/password fields, so maybe it was supposed to be an if-else instead of just an if conditional?

As for a PR, I'd love to but I'm still learning Django and Tailwind so I can't right now unfortunately.

danihodovic commented 6 months ago

I will see if I can open a PR. Good catch