replace AT_ASSERT with AT_CHECK

daniilidis-group / neural_renderer

A PyTorch port of the Neural 3D Mesh Renderer

Other

1.12k stars 248 forks source link

replace AT_ASSERT with AT_CHECK #21

Closed wangg12 closed 5 years ago

wangg12 commented 5 years ago

@nkolot Changed to AT_CHECK, the last PR contains jit compile which may be not needed. So I opened another one.

nkolot commented 5 years ago

One last thing you need to do now that we are in PyTorch 0.4.1 is to go to each of the 3 .cpp files and uncomment PYBIND11_MODULE(TORCH_EXTENSION_NAME, m) (and also delete the next line which is not necessary anymore). After that you should be ready to merge.

wangg12 commented 5 years ago

@nkolot Done.