search

daniilidis-group / neural_renderer

A PyTorch port of the Neural 3D Mesh Renderer
Other
1.14k stars 254 forks source link

Ghost texture #25

Closed fxia22 closed 6 years ago

fxia22 commented 6 years ago

This commit needs to be applied: https://github.com/hiroharu-kato/neural_renderer/commit/310d8b55abc050bd3d0ac1a0c9e6e4cfa6bb3336

nkolot commented 6 years ago

Can you make the change and submit a PR?

fxia22 commented 6 years ago

Sure there you have it #26 :)

czw0078 commented 6 years ago

@fxia22 FYI: to avoid the wrong gradient (NaN), please look this #27

nkolot commented 6 years ago

So you are saying that I should merge the other PR, correct?

czw0078 commented 6 years ago

Right, I tested it. The >0 condition prevents the divided by zero problems.

fxia22 commented 6 years ago

Yes, please merge the other PR instead. Thanks.