search

daniilidis-group / neural_renderer

A PyTorch port of the Neural 3D Mesh Renderer
Other
1.14k stars 254 forks source link

support setting image_size=(width, height) #45

Open hzsydy opened 5 years ago

nkolot commented 5 years ago

Did you verify that it still passes the existing test cases? I cannot test it myself for the next few days.

hzsydy commented 5 years ago

Even daniilidis-group/neural_renderer branch itself cannot pass the test cases. Renderer.render() now returns a tuple instead of a single image, so most of the test cases just failed.

hzsydy commented 5 years ago

fix a bug in orig_size I wrote, which is not tested in testcase lol

nkolot commented 5 years ago

Sorry for not being very responsive. What is the status of this PR?

hzsydy commented 5 years ago

I believe it works (because I am using it now), but not exactly sure.

nkolot commented 5 years ago

From a quick look it doesn't not break backwards compatibility. I will try to write some small unit tests, and if it passes I will merge it.

EricCousineau-TRI commented 3 years ago

FWIW I think I've done some basic fixing of unittests in #115 (well, relaxing the failing mask intersections at least)