search

daniilidis-group / neural_renderer

A PyTorch port of the Neural 3D Mesh Renderer
Other
1.14k stars 254 forks source link

Only square images? #7

Open pmcrodrigues opened 6 years ago

pmcrodrigues commented 6 years ago

Hi, nice work with this! I am correct in saying that this is only for square images? Are you planning to extend it to generic images?

nkolot commented 6 years ago

It's fairly straightforward to make it work for rectangular images. Will do it some time this week.

jbohnslav commented 6 years ago

What's the status on this?

nkolot commented 6 years ago

It appears that it's not as easy as I originally expected. Basically the forward pass is straightforward to implement, but for the backward pass there were some things in the code that were not clear how exactly it works. Feel free to fix it and submit a PR, I am quite busy currently, so I can't work on it.