danijar / dreamerv3

Mastering Diverse Domains through World Models
https://danijar.com/dreamerv3
MIT License
1.28k stars 219 forks source link

About running statistics #153

Open Warry98 opened 1 week ago

Warry98 commented 1 week ago

When computing moments (percentiles or others), shouldn't the statistics be weighted by the weights computed here to exclude the terminated trajectories in the calculation? https://github.com/danijar/dreamerv3/blob/251910d04c9f38dd9dc385775bb0d6efa0e57a95/dreamerv3/agent.py#L301