Custom html document title

danijar / handout

Turn Python scripts into handouts with Markdown and figures

Apache License 2.0

2.02k stars 106 forks source link

Closed epogrebnyak closed 5 years ago

epogrebnyak commented 5 years ago

Html file title is currently is hardcoded Handout. A user might want to override it with custom title, something like "Jane's awesome notebook"

Implemetation would require small change in constructor as below:

class Handout(object):

  def __init__(self, directory, title="Handout"):

danijar commented 5 years ago

Thanks for the feature request, that seems very doable.

epogrebnyak commented 5 years ago

I can do a PR for this feature, it looks rather straight-forward.

Is there a unit testing strategy that you have in mind - maybe, pytest? Can move testing discussion to a separate issue if you want.

epogrebnyak commented 5 years ago