danikf / tik4net

Manage mikrotik routers with .NET C# code via ADO.NET like API or enjoy O/R mapper like highlevel api.
Apache License 2.0
174 stars 93 forks source link

ApiConnection change for new login process: RouterOS Version > 6.43. Fixes #28 #29

Closed DaveSchmid closed 6 years ago

DaveSchmid commented 6 years ago

Mikrotik has changed the authentication process for API login in 6.43rc19 (2018-May-25 08:48). Wiki: https://wiki.mikrotik.com/wiki/Manual:API#Initial_login

danikf commented 6 years ago

Hi,

thanks for this code. I would preffer to create new connection types (TikConnectionType - ApiNew, ApiSslNew) instead of parameter oldLogin (ConnectionFactory) because of the bakcward compatibility with older code.

Do you agree? I could do it myself during pull request merge process ...

D

DaveSchmid commented 6 years ago

Yes you are right, the optional arguments are only since C# 4.0. New ConnectionTypes are a much better Idea. Please do it the way you like it best.