search

danikf / tik4net

Manage mikrotik routers with .NET C# code via ADO.NET like API or enjoy O/R mapper like highlevel api.
Apache License 2.0
174 stars 93 forks source link

Additional objects and fixes #4

Closed D-Bullock closed 8 years ago

D-Bullock commented 8 years ago

Hi,

I've updated various data types that weren't working when I went to retrieve data. I've added a Hotspot active object. I've added a util to help manage MikroTik's weird time formats (perhaps this could be integrated into the models to avoid exposing the consumer to timespan strings) And I pulled HotspotUserProfile out of the HotspotUser file. This is because it wasn't obvious to look for it there - I'd actually gone about creating a new object before realising it already exists.

I've not submitted a pull request before before so let me know if I'm doing it wrong...

danikf commented 8 years ago

Hi,

thank you for your work. I will integrate it into core in when I will have some time (give me aprox one week please :-) ).

D

danikf commented 8 years ago

Hi, I have just incorporated your code into codebase with some minor changes:

1) MS C# standard formating 2) tik4net namespaces 3) MTikTimeUtils -> TikTimeHelper (+ namespace change) 4) TikTimeHelper (MTikTimeUtils) code tunnings 5) TikTimeHelper (MTikTimeUtils) behavior for "0" changed to meet unittest requirements

Thank you for sharing! D