search

danilevsky / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

GDI+ backend doesn't handle FXDIB_Rgba, CMYK bitmaps #188

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
clang-cl warns:

..\..\third_party\pdfium\core\src\fxge\win32\fx_win32_gdipext.cpp(435,13) :  
error(clang): 10 enumeration values not handled in switch: 
'FXDIB_Invalid', 'FXDIB_1bppMask', 'FXDIB_8bppMask'... 
[-Werror,-Wswitch]
    switch (pBitmap->GetFormat()) {
            ^

The switch is missing these cases:

        case FXDIB_8bppRgba:
        case FXDIB_1bppCmyk:
        case FXDIB_8bppCmyk:
        case FXDIB_8bppCmyka:
        case FXDIB_Rgba:
        case FXDIB_Cmyk:
        case FXDIB_Cmyka:

        case FXDIB_Invalid:
        case FXDIB_1bppMask:
        case FXDIB_8bppMask:

FXDIB_Invalid can probably just do nothing. I don't know what to do with the 
mask cases. The other 7 are likely just not implemented and need to be 
implemented? This code really hasn't been touched much since the initial commit 
– Bo, do you know what needs to be done here?

Original issue reported on code.google.com by thakis@chromium.org on 24 Jul 2015 at 3:16

GoogleCodeExporter commented 9 years ago

Original comment by thakis@chromium.org on 24 Jul 2015 at 3:17

GoogleCodeExporter commented 9 years ago 
Jun, can you ask your developers about this? Thanks!

Original comment by tsepez@chromium.org on 24 Jul 2015 at 5:57

GoogleCodeExporter commented 9 years ago 
Jun: Ping.

Original comment by thakis@chromium.org on 16 Aug 2015 at 6:26