Open GoogleCodeExporter opened 8 years ago
By posting the shell script above, I'm guessing that you're not willing to take
a stab at this Nico? I'd be grateful ! Otherwise just assign this to me.
Original comment by tsepez@chromium.org
on 6 Aug 2015 at 10:23
Probably better if someone working with the people working on the xfa branch
does this, so that there's a chance of it not regressing very quickly.
(Doing the conversion and checking in the files with the new line endings
should take 4 minutes, so that part is easy.)
Original comment by thakis@chromium.org
on 7 Aug 2015 at 6:28
|{x: x is working on the xfa branch}| == 0. We're pretty much just merging
until I can get the tests straightened out on main.
Original comment by tsepez@chromium.org
on 7 Aug 2015 at 6:37
Don't we have a DOS line ending presubmit check in Chromium? Should we run sed
and put in the presubmit check to enforce the line ending?
Original comment by thestig@chromium.org
on 21 Aug 2015 at 6:34
I couldn't find one when I looked for one for 2 minutes. I'm all for fixing
this and having a presubmit, though.
Original comment by thakis@chromium.org
on 25 Aug 2015 at 8:48
Oh, come on. Work those grep skills!
$ grep -i ending /path/to/chrome/src/PRESUBMIT.py
...
_CheckForWindowsLineEndings(...)
Original comment by thestig@chromium.org
on 4 Sep 2015 at 9:36
That checks file types txt|html|htm|mhtml|py|gyp|gypi|gn|isolate from what I
can tell :-P
(Also, it reads all lines of all these file types on presubmit – I wonder if
that's why presubmits have been even slower than usual in the last few
months…)
Original comment by thakis@chromium.org
on 4 Sep 2015 at 4:42
Original issue reported on code.google.com by
thakis@chromium.org
on 6 Aug 2015 at 10:20