search

daniloaf / moviesnetwork

1 stars 0 forks source link

Issue13 and Issue15 #18

Closed daniloaf closed 8 years ago

amaurymedeiros commented 8 years ago

PEP 0008 says to use no more than 79 characters. https://www.python.org/dev/peps/pep-0008/#id14

daniloaf commented 8 years ago

I know that. I just prefer 120 for a better visualization. There are other lines with more than 80 characters.

But it's better using pep8 recommendations. Em 31/12/2015 12:45, "Amaury" notifications@github.com escreveu:

PEP 0008 says to use no more than 79 characters. https://www.python.org/dev/peps/pep-0008/#id14

— Reply to this email directly or view it on GitHub https://github.com/daniloaf/moviesnetwork/pull/18#issuecomment-168212546 .

amaurymedeiros commented 8 years ago

I pointed out few other lines > 80. The problem is it makes difficult to maintain and review. I have a 15" retina display and the line is wrapped when I try to review in github. Also, shorter lines help to split the screen in half, which most developers do.