ISSUE fix padval type is float when chunk format is not 'f'.

danilobellini / audiolazy

Expressive Digital Signal Processing (DSP) package for Python

GNU General Public License v3.0

689 stars 74 forks source link

ISSUE fix padval type is float when chunk format is not 'f'. #5

Open mobilefzb opened 7 years ago

mobilefzb commented 7 years ago

When I use audiolazy to read a mp3 file, it seems that the chunk format is type 'h', the padval default is 0., it can not be used for integer.

Thanks, Zhibo

coveralls commented 7 years ago

Coverage increased (+0.004%) to 88.271% when pulling fc2fb7b962b27a27d92d1b265ef5327b676d0042 on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

coveralls commented 7 years ago

Coverage increased (+0.004%) to 88.271% when pulling fc2fb7b962b27a27d92d1b265ef5327b676d0042 on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

coveralls commented 7 years ago

Coverage increased (+0.004%) to 88.271% when pulling fc2fb7b962b27a27d92d1b265ef5327b676d0042 on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

coveralls commented 7 years ago

Coverage increased (+0.004%) to 88.271% when pulling fc2fb7b962b27a27d92d1b265ef5327b676d0042 on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

danilobellini commented 7 years ago

Nice catch! Just amend it to make "d" (for double) also kept as 0.0 and that'll be merged.

The commit message can be "Fix padval type when chunk format isn't float". You can choose any other commit subject and body message you like but please keep the subject with up to 50 characters, as I'm trying to follow the seven rules of a great Git commit message in my projects.

Thanks!

mobilefzb commented 7 years ago

OK, I will update related code and then make a new pull request.

Thanks, Zhibo

coveralls commented 7 years ago

Coverage decreased (-0.08%) to 88.19% when pulling fce1d5764668b44f938dbd48d0fa2ed456c16690 on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

coveralls commented 7 years ago

Coverage decreased (-0.08%) to 88.19% when pulling fce1d5764668b44f938dbd48d0fa2ed456c16690 on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

coveralls commented 7 years ago

Coverage decreased (-0.07%) to 88.195% when pulling 0192bfbc3892194ddbae86d25438738f31fd1973 on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

coveralls commented 7 years ago

Coverage decreased (-0.07%) to 88.195% when pulling 0192bfbc3892194ddbae86d25438738f31fd1973 on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

danilobellini commented 7 years ago

Do:

git rebase --onto HEAD~3 HEAD^

with a forced push afterwards. That command will remove the 2 "back and forth" commits.

For editing the last commit, you can always use git commit --amend. The author name and e-mail for your commit changed, was that intended? If not, you still can fix that. =)

About the Python syntax, you can use if some_variable in ["a", "b"]: instead of if some_variable == "a" or some_variable == "b":. I'm ok with any of these, don't worry ;)

I'll wait for the rebase. If you need any help or explanation, please let me know.

Thanks!

mobilefzb commented 7 years ago

Ok, sounds good. I will try. :)

Thanks, Zhibo

coveralls commented 7 years ago

Coverage increased (+0.004%) to 88.271% when pulling efbb80cf4429263c57272163aa4b62a16d07656e on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

coveralls commented 7 years ago

Coverage increased (+0.004%) to 88.271% when pulling efbb80cf4429263c57272163aa4b62a16d07656e on mobilefzb:master into dba0a278937909980ed40b976d866b8e97c35dee on danilobellini:master.

danilobellini commented 7 years ago

I don't really understand what's going on with these commits going back and forth, but I think you want to keep Zhibo Fu <mobilefzb@163.com> as your author and committer name/e-mail pairs. Let's squash it into a single commit:

git checkout master
git reset v0.6
GIT_AUTHOR_NAME="Zhibo Fu" GIT_AUTHOR_EMAIL="mobilefzb@163.com" GIT_COMMITTER_NAME="Zhibo Fu" GIT_COMMITTER_EMAIL="mobilefzb@163.com" git commit -am "Fix padval type when chunk format isn't float"
git push --force