search

danilobuerger / redux-implicit-oauth2

OAuth 2.0 Implicit Grant Flow with Redux
MIT License
30 stars 20 forks source link

Added support for IG and LI #14

Closed shekoufa closed 6 years ago

shekoufa commented 6 years ago

In this PR, I added support for logging in via Instagram and Linkedin since these two behave differently compared to facebook where it responds with access_token and state as hash parameters. Linkedin returns both as query parameters (it also returns code instead of access_token) and IG returns the access token as a hash parameter but the state is actually a query parameter.

danilobuerger commented 6 years ago

@shekoufa are you still interested in pursuing this?

shekoufa commented 6 years ago

Hey Danilo. Yes. Absolutely. The thing is I recently changed my job and I was in the onboarding process the two previous weeks. I'll try to apply your comments next weekend and hopefully we can get it merged after that.

Cheers, Navid

On Sun, Apr 8, 2018, 18:22 Danilo Bürger, notifications@github.com wrote:

@shekoufa https://github.com/shekoufa are you still interested in pursuing this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/danilobuerger/redux-implicit-oauth2/pull/14#issuecomment-379581641, or mute the thread https://github.com/notifications/unsubscribe-auth/AL9bI1As2jFXRe21Rcr-fKyGZEoeGLI_ks5tmniLgaJpZM4Se4sf .

danilobuerger commented 6 years ago

Closing due to inactivity.