search

daniloc / PicoW_HomeAssistant_Starter

Everything you need to get started with your own Intranet of Things, using the high-quality, low-cost Pico W as the backbone.
MIT License
198 stars 20 forks source link

[SUGGESTION] Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup() #16

Open JacobChrist opened 11 months ago

JacobChrist commented 11 months ago

Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup() for more orthogonal naming with the Wiring/Arduino naming conventions.

I feel like begin() better matches other Arduino classes in how its used, but because of the loop() it really feels like it should be called setup().

Frankly, configure() doesn't really bother me either, but I think begin() or setup() really hits home as to what this function is doing and where it probably should be called from.

daniloc commented 11 months ago

Yeah, thanks for thinking about this, I agree. begin() is probably the most culturally idiomatic. You've got a few thoughts brewing, want to open a PR to reflect this change?