daniloc / PicoW_HomeAssistant_Starter

Everything you need to get started with your own Intranet of Things, using the high-quality, low-cost Pico W as the backbone.
MIT License
198 stars 20 forks source link

Suggestion: Add note in HAIntegration.cpp #8

Open JacobChrist opened 1 year ago

JacobChrist commented 1 year ago

Suggestion: Add note in HAIntegration.cpp that HASwitch(uniqueid) must not contain spaces.

HASwitch led("led");  // unique identifier must not contain spaces
daniloc commented 1 year ago

Nice catch! I'm open to a pull request to this effect.

JacobChrist commented 1 year ago

While looking around at the arduino-home-assistant examples I notices that you can set the icon, I do a pull request for this issue, would you mind if I changed the default icon for the LED?

    led.setIcon("mdi:led-outline"); // optional

image

daniloc commented 1 year ago

Oh that's a terrific addition, hell yes, thank you.