search

danilogio / ostinato

Automatically exported from code.google.com/p/ostinato
GNU General Public License v3.0
0 stars 0 forks source link

Impossible to modify TCP checksum. #58

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Edit on a stream
2. Modify a TCP checksum
3. Clock OK and Apply
4. Open the stream

What is the expected output? What do you see instead?

The TCP checksum is not modified.

What version and revision of the product are you using (available in the
About dialog)? On what operating system?

Build from latest mercurial.

Please provide any additional information below.

The problem is that the string format is not well interpreted when read back: 
it seems not possible to convert the formatted string to an integer by using 
the string function.

I attach to the ticket a patch that fix the issue. It is not meant to be 
applied but show where the problem is.

Original issue reported on code.google.com by eric.leb...@gmail.com on 21 Dec 2011 at 4:50

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by pstav...@gmail.com on 22 Dec 2011 at 1:59

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 807e85df64ed.

Original comment by pstav...@gmail.com on 22 Dec 2011 at 2:00

GoogleCodeExporter commented 9 years ago 
@eric: Thanks for reporting this issue. I have fixed it in the repo - please 
pull and check.

Original comment by pstav...@gmail.com on 22 Dec 2011 at 2:01

GoogleCodeExporter commented 9 years ago 
I've just updated, build and installed ostinato but it does not work. I'm sure 
the update has been made because I don't see any trace of my POC patch.

Original comment by eric.leb...@gmail.com on 22 Dec 2011 at 2:33

GoogleCodeExporter commented 9 years ago 
@eric: Please recheck. It works fine for me . Make sure that your code is 
updated as per the following patch and you have built it and are running the 
correct binary.

http://code.google.com/p/ostinato/source/diff?spec=svn807e85df64ed036584dab21676
b457ea690f1caf&old=f99d5b97f3d9b2e9837204af9f2c9327cb66716c&r=807e85df64ed036584
dab21676b457ea690f1caf&format=unidiff&path=%2Fcommon%2Ftcp.cpp

Make sure

Original comment by pstav...@gmail.com on 23 Dec 2011 at 1:50

GoogleCodeExporter commented 9 years ago 
Oups my fault, I get confused with mercurial pull command which do not work 
like git pull. Issue fixed! I'm really sorry for the false alarm...

Original comment by eric.leb...@gmail.com on 23 Dec 2011 at 4:07

GoogleCodeExporter commented 9 years ago 
Ah, I guess you didn't do a "hg update" to update your working copy!

Closing the issue.

Original comment by pstav...@gmail.com on 23 Dec 2011 at 4:29