depot_tools fails on Windows

[GoogleCodeExporter]

What steps will reproduce the problem?
1. get new depot tools
2. gclient sync
3. python gyp_libyuv -fninja -G msvs_version=2013 libyuv_test.gyp

What is the expected output? 
should sync and/or build

What do you see instead?
fails to sync or build

Please use labels and text to provide additional information.

depot_tools from 03/25/2015 work
affects all gyp based projects, not just libyuv.

Original issue reported on code.google.com by fbarch...@chromium.org on 25 Mar 2015 at 5:27

[GoogleCodeExporter]

For the build error, this is what I get:

d:\src\libyuv\trunk>call python gyp_libyuv -fninja -G msvs_version=2013 
libyuv_test.gyp
Updating projects from gyp files...
Traceback (most recent call last):
  File "gyp_libyuv", line 89, in <module>
    gyp_rc = gyp.main(args)
  File "d:\src\libyuv\trunk\tools\gyp\pylib\gyp\__init__.py", line 526, in main
    return gyp_main(args)
  File "d:\src\libyuv\trunk\tools\gyp\pylib\gyp\__init__.py", line 511, in gyp_main
    generator.GenerateOutput(flat_list, targets, data, params)
  File "d:\src\libyuv\trunk\tools\gyp\pylib\gyp\generator\ninja.py", line 2387, in GenerateOutput
    pool.map(CallGenerateOutputForConfig, arglists)
  File "C:\python_27_amd64\files\lib\multiprocessing\pool.py", line 227, in map
    return self.map_async(func, iterable, chunksize).get()
  File "C:\python_27_amd64\files\lib\multiprocessing\pool.py", line 528, in get
    raise self._value
Exception: Environment variable "SYSTEMROOT" required to be set to valid path

gclient sync also fails, but it syncs up code, so I suspect its in runhooks.
If I go back to old depot tools, from mar 2014, it works.

Original comment by fbarch...@chromium.org on 25 Mar 2015 at 8:09

[GoogleCodeExporter]

I believe SYSTEMROOT is a default environment variable that should exist on all 
Windows systems, so I don't think it's invalid that depot tools relies on it 
being set.

Setting it resolves this issue. I guess your machine somehow got it unset.

Original comment by kjellan...@google.com on 26 Mar 2015 at 10:23

• Changed state: Invalid