search

danilop / yas3fs

YAS3FS (Yet Another S3-backed File System) is a Filesystem in Userspace (FUSE) interface to Amazon S3. It was inspired by s3fs but rewritten from scratch to implement a distributed cache synchronized by Amazon SNS notifications. A web console is provided to easily monitor the nodes of a cluster.
http://danilop.github.io/yas3fs
MIT License
640 stars 98 forks source link

Fixes issues/141 #148

Closed liath closed 7 years ago

liath commented 7 years ago

wrapped JSON parse in a try-except

liath commented 7 years ago

Something like this maybe?

logger.debug("parsing error: %s" % (e))
logger.warn("process_message discarding malformed message")

process_message only has the message body unfortunately. Maybe we could let it throw and catch the exception in listen_for_messages_over_sqs? Not familiar enough python to know if that would even work.

liath commented 7 years ago

Should I merge myself? I'm used to my companies rules against merging your own changes lol

dacut commented 7 years ago

My hunch is as long as you get the thumbs up, you’re good to go on the merge.

That said, I went ahead and merged it so my neck is officially on the line, too. :-)

liath commented 7 years ago

Thank you. I just felt like I might be treading too heavily, but you make a compelling point about sharing blame lol