danilowoz / react-content-loader

⚪ SVG-Powered component to easily create skeleton loadings.
https://skeletonreact.com
MIT License
13.77k stars 420 forks source link

fix(svg): migrate defaultProps to default parameters #305

Closed TotomInc closed 1 year ago

TotomInc commented 1 year ago

defaultProps is deprecated and will be removed from function components

fix #298

Summary

There's an error because this lib is using defaultProps for the SVG.tsx component. defaultProps are deprecated in function components.

CleanShot 2023-03-03 at 13 25 55@2x

A simple fix is to migrate defaultProps to default JS parameters.

Related Issue #[issue number]

298 has been opened, thanks to @shehi for pointing out the file to update.

Any Breaking Changes

There is no breaking changes.

Checklist

codesandbox[bot] commented 1 year ago

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

shehi commented 1 year ago

@danilowoz , this looks good. Can you review, merge and release this please?

shehi commented 1 year ago

@danilowoz . v6.2.0 apparently doesn't contain this fix. It seems release checks failed. Can you please check and make a release with this? Thanks.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 6.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: