danilowoz / react-content-loader

⚪ SVG-Powered component to easily create skeleton loadings.
https://skeletonreact.com
MIT License
13.78k stars 421 forks source link

Skeletons animations are not working in the latest Chrome version #316

Closed varayoudfederico closed 8 months ago

varayoudfederico commented 9 months ago

What did you do?

Opened the examples page: https://skeletonreact.com/#gallery in Chome latest version (122.0.6261.58).

What did you expect to happen?

The skeletons animate correctly.

What happened actually?

The skeletons are not animating, they remain static.

Which versions of react-content-loader, and which browser are affected by this issue?

Locally we use React 18.2.0 and version 6.2.1 of the library. But the issue can be replicated in the examples page.

dakioso commented 9 months ago

Same here! And i'm running on a bit newer Chrome version: 122.0.6261.69

marjon4 commented 9 months ago

+1

azzinijuli commented 9 months ago

I'm having the same issue with Chrome v 122.0.6261.70

ekkotest commented 9 months ago

me too

Cow258 commented 9 months ago

I got same issue on Chrome 122.0.6261.69 (arm64)

Chrome 122.0.6261.69 (arm64)

image

Safari 17.3.1(19617.2.4.11.12)

image

GauthierWillemse commented 9 months ago

+1

jwebbvalent commented 9 months ago

+1

Roeefl commented 9 months ago

We're having the same issue on Brave since updating from v1.62 to v1.63 (Released Feb 28, 2024), which includes chromium upgrade to 122.0.6261.94

jabranrafique commented 9 months ago

Not animating for me on MS Edge Version 122.0.2365.59

shimi-kuperli commented 8 months ago

+1

Roeefl commented 8 months ago

@danilowoz we need you responding here or people gonna start forking.

Roeefl commented 8 months ago

I love David Bokan and his Chromium changes

https://chromium.googlesource.com/chromium/src/+/a1f3b8804d221a3c503224c6b558eb19df29e9a0

danilowoz commented 8 months ago

Hello everyone! Unfortunately, this seems to be a breaking change introduced in the Chromium animation API that react-content-loader heavily relies on. There must be a valid reason for the Chromium team to implement such a change, and the only solution is to find an alternative approach to keep this library running.

I can't promise a timeline, as this is a challenging issue and I've been busy with my usual work on CodeSandbox. But if anyone finds a good solution I will make sure to review it as soon as possible and get it merged 🙏

Roeefl commented 8 months ago

Thanks a lot for the update @danilowoz will keep you updated if we come up with anything

Roeefl commented 8 months ago

@danilowoz We've tried to figure this out and indeed this seems to be a breaking change in Chromium regrading animations for linear-gradients only (I think).

For the meanwhile, we've cloned the Svg.tsx file from your repo (thank you!) and simplified it to have it's opacity animated rather than a gradient, just to keep our Production content loaders giving a loading indication.

If this might help you in any way, this is our forked file: https://gist.github.com/Roeefl/af6e9192aee30c4c120101b70f7f8837

danilowoz commented 8 months ago

I think I've found an alternative! Is someone up to review and look for inconsistency? I'm pretty sure we will end up deprecating some props, btw