search

danimahardhika / candybar-library

Android icon pack material dashboard
Apache License 2.0
496 stars 143 forks source link

Wrong appmap.xml builder #103

Closed xorRisont closed 7 years ago

xorRisont commented 7 years ago

In icon request mail (containing in *.zip) appmap.xml has wrong activity configuration. Needed com.package.Activity, but we have com.package. Example: auto builded string: <item class="com.tencent.mm" name="wechat" /> Right string: <item class="com.tencent.mm.ui.LauncherUI" name="wechat" />

Appmap using in Atom Launcher and configuration like "com.package" don't work

danimahardhika commented 7 years ago

That's correct. It should be package name not activity

xorRisont commented 7 years ago

@danimahardhika then why Atom launcher don't work (if i use only package name?), but if i add package.Activity - icon works in Atom Launcher

danimahardhika commented 7 years ago

Sorry my bad, it should be the activity

xorRisont commented 7 years ago

@danimahardhika but if a change in RequestHelper.java:360 "\t<item class=\"" + request.getPackageName() + "\" name=\"" + to "\t<item class=\"" + request.getActivity() + "\" name=\"" + i get format: com.package/com.package.Activity right?

UPD: yep. i get wrong format: package/package.Activity