fixed two errors with the Mittsu::MeshFaceMaterial

danini-the-panini / mittsu

3D Graphics Library for Ruby.

https://github.com/danini-the-panini/mittsu

MIT License

510 stars 33 forks source link

fixed two errors with the Mittsu::MeshFaceMaterial #53

Closed ThunderKey closed 7 years ago

ThunderKey commented 7 years ago

I've found to errors whilst using the Mittsu::MeshFaceMaterial in a Mittsu::Mesh.

In lib/mittsu/renderers/opengl/core/object_3d.rb:105 there is a reference to MeshFaceMaterial#materials and OpenGLGeometryGroup#material_index which both are only instance variables without a getter.

I've tried to get the testing to run, to implement a test for that. Unfortunately I only get the error Unsupported platform. The Platform seems to be :OPENGL_PLATFORM_TEST

danini-the-panini commented 7 years ago

Hi @ThunderKey, sorry I haven't been active lately, it's been a pretty hectic month for me. Thank you for your contribution to Mittsu!

I've had a look at the issue you are having with the tests and have fixed the issue in #54 which has now been merged into master. Please check again and let me know if you have any other issues. 👍

ThunderKey commented 7 years ago

@jellymann Thanks for fixing the issue with the tests. I have added a basic test for Mittsu::MeshFaceMaterial in https://github.com/jellymann/mittsu/pull/53/commits/0c1c28f8ade8effa9401c3d5deb6cdc7d0142b8d. Hopefully this helps.